[webkit-reviews] review granted: [Bug 203719] Web Inspector: Sources: tab isn't visible after removal of Debugger Tab and Resources Tab : [Attachment 382545] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted  review:
Bug 203719: Web Inspector: Sources: tab isn't visible after removal of Debugger
Tab and Resources Tab
https://bugs.webkit.org/show_bug.cgi?id=203719

Attachment 382545: Patch

https://bugs.webkit.org/attachment.cgi?id=382545&action=review




--- Comment #5 from Brian Burg <bburg at apple.com> ---
Comment on attachment 382545
  --> https://bugs.webkit.org/attachment.cgi?id=382545
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382545&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/Main.js:154
> +    // Replace the Debugger/Resources Tab with the Sources Tab.

Please extract this into a separate function. Maybe even a separate file like
MigrationUtilities.js. When we decide this code is no longer worth the trouble
(say, Catalina + 1, or based on telemetry showing its use has diminished) then
we can easily remove it.

> Source/WebInspectorUI/UserInterface/Base/Main.js:155
> +    let debuggerIndex = WI._openTabsSetting.value.indexOf("debugger");

It seems weird we have a symbolic name for "debugger" or "resources" tab?