[webkit-reviews] review denied: [Bug 182686] Basic OffscreenCanvas functionality : [Attachment 382585] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 1 09:16:11 PDT 2019

Antti Koivisto <koivisto at iki.fi> has denied Chris Lord <clord at igalia.com>'s
request for review:
Bug 182686: Basic OffscreenCanvas functionality

Attachment 382585: Patch


--- Comment #12 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 382585
  --> https://bugs.webkit.org/attachment.cgi?id=382585

View in context: https://bugs.webkit.org/attachment.cgi?id=382585&action=review

> Source/WebCore/css/parser/CSSPropertyParser.cpp:487
> -static RefPtr<CSSFontFeatureValue>
consumeFontFeatureTag(CSSParserTokenRange& range)
> +static RefPtr<CSSFontFeatureValue> consumeFontFeatureTag(CSSValuePool&
cssValuePool, CSSParserTokenRange& range)

We are not going to uglify the code by adding CSSValuePool argument everywhere.
Please find alternative solutions, like using thread global data.

> Source/WebCore/css/parser/CSSPropertyParser.cpp:689
> +static RefPtr<CSSValue> consumeFontVariantEastAsian(CSSValuePool&
cssValuePool, CSSParserTokenRange& range)

We are not going to start passing

More information about the webkit-reviews mailing list