[webkit-reviews] review requested: [Bug 203722] Web Inspector: REGRESSION(r249831): content view is empty if a breakpoint is hit in the main resource : [Attachment 382565] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has asked  for review:
Bug 203722: Web Inspector: REGRESSION(r249831): content view is empty if a
breakpoint is hit in the main resource
https://bugs.webkit.org/show_bug.cgi?id=203722

Attachment 382565: Patch

https://bugs.webkit.org/attachment.cgi?id=382565&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Created attachment 382565

  --> https://bugs.webkit.org/attachment.cgi?id=382565&action=review

Patch

This gets part of the way there, in that the content is now visible.

But there appears to be another issue, which is that the initial content is now
just the inline script content, rather than the entire HTML document.  This
seems to have been caused by r249831.  My guess as to why that's happening is
that the timing of showing the pause location within the inline script is now
not working correctly since we have to wait for the formatted HTML content,
which is asynchronous.	I think we should either not auto-format HTML resources
if we're showing a pause location the first time the resource is shown or try
to delay the highlighting code until after the format is complete.