[webkit-reviews] review granted: [Bug 198432] REGRESSION: WebKit.InteractionDeadlockAfterCrash and SynchronousTimeoutTests.UnresponsivePageDoesNotCausePositionInformationToHangUI API tests are failing : [Attachment 371080] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 31 14:01:40 PDT 2019


Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 198432: REGRESSION: WebKit.InteractionDeadlockAfterCrash and
SynchronousTimeoutTests.UnresponsivePageDoesNotCausePositionInformationToHangUI
API tests are failing
https://bugs.webkit.org/show_bug.cgi?id=198432

Attachment 371080: Patch

https://bugs.webkit.org/attachment.cgi?id=371080&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 371080
  --> https://bugs.webkit.org/attachment.cgi?id=371080
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371080&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:62
> +    [[webView wkContentView] hasSelectablePositionAtPoint:CGPointZero];

I just realized -wkContentView exists :P

I typically use -textInputContentView, which is nearly the same thing.


More information about the webkit-reviews mailing list