[webkit-reviews] review granted: [Bug 198318] Optionally respect device management restrictions when loading from the network : [Attachment 371016] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 31 11:41:14 PDT 2019
Alex Christensen <achristensen at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 198318: Optionally respect device management restrictions when loading from
the network
https://bugs.webkit.org/show_bug.cgi?id=198318
Attachment 371016: Patch
https://bugs.webkit.org/attachment.cgi?id=371016&action=review
--- Comment #21 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 371016
--> https://bugs.webkit.org/attachment.cgi?id=371016
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=371016&action=review
> Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceManagementRestrictions.mm:54
> + EXPECT_EQ(kWKErrorCodeFrameLoadBlockedByRestrictions, error.code);
This should be a value from WKErrorPrivate.h instead of from the C API. Also
check the domain.
More information about the webkit-reviews
mailing list