[webkit-reviews] review granted: [Bug 198412] [iOS] Reveal the focused element when it's immediately above software keyboard : [Attachment 371045] Fixes the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 31 08:01:19 PDT 2019


Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 198412: [iOS] Reveal the focused element when it's immediately above
software keyboard
https://bugs.webkit.org/show_bug.cgi?id=198412

Attachment 371045: Fixes the bug

https://bugs.webkit.org/attachment.cgi?id=371045&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 371045
  --> https://bugs.webkit.org/attachment.cgi?id=371045
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=371045&action=review

We should double check that this doesn't cause the scroll position to jump in
Mail compose when focusing the body field by tapping near the bottom of the
compose window.

>
LayoutTests/fast/scrolling/ios/reveal-focused-element-right-above-keyboard-on-i
pad.html:33
> +	   UIHelper.isIOS = () => true;

OOPS! I filed <rdar://problem/51301737> to track this.


More information about the webkit-reviews mailing list