[webkit-reviews] review granted: [Bug 198316] run-benchmark should report an error if the argument to --build-directory is bogus : [Attachment 371020] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 30 23:49:52 PDT 2019


Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 198316: run-benchmark should report an error if the argument to
--build-directory is bogus
https://bugs.webkit.org/show_bug.cgi?id=198316

Attachment 371020: Patch

https://bugs.webkit.org/attachment.cgi?id=371020&action=review




--- Comment #11 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 371020
  --> https://bugs.webkit.org/attachment.cgi?id=371020
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371020&action=review

>
Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:41
> +		   env = {'DYLD_FRAMEWORK_PATH': browser_build_absolute_path,
'DYLD_LIBRARY_PATH': browser_build_absolute_path, '__XPC_DYLD_FRAMEWORK_PATH':
browser_build_absolute_path, '__XPC_DYLD_LIBRARY_PATH':
browser_build_absolute_path}

Can we split this into multiple lines? It's really long now.


More information about the webkit-reviews mailing list