[webkit-reviews] review granted: [Bug 198301] IsoHeaps don't notice uncommitted VA becoming the first eligible. : [Attachment 370963] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 198301: IsoHeaps don't notice uncommitted VA becoming the first eligible.
https://bugs.webkit.org/show_bug.cgi?id=198301

Attachment 370963: Patch

https://bugs.webkit.org/attachment.cgi?id=370963&action=review




--- Comment #7 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 370963
  --> https://bugs.webkit.org/attachment.cgi?id=370963
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370963&action=review

r=me

> Source/bmalloc/bmalloc/IsoDirectoryInlines.h:51
> +    BASSERT((m_eligible | ~m_committed).findBit(0, true) == pageIndex);

Nice!

> Source/bmalloc/bmalloc/IsoHeapImpl.h:84
> +    void didBecomeEligibleOrDecommited(IsoDirectory<Config,
numPagesInInlineDirectory>*);
> +    void didBecomeEligibleOrDecommited(IsoDirectory<Config,
IsoDirectoryPage<Config>::numPages>*);

This is nice and cleaner.

> Source/bmalloc/bmalloc/IsoHeapImplInlines.h:202
> +

Let's drop this blank line.