[webkit-reviews] review granted: [Bug 198298] REGRESSION (r245756) [Mac] 2 TestWebKitAPI.DownloadProgress* and TestWebKitAPI._WKDownload.DownloadMonitorCancel are flaky timeouts : [Attachment 370906] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted David Quesada
<david_quesada at apple.com>'s request for review:
Bug 198298: REGRESSION (r245756) [Mac] 2 TestWebKitAPI.DownloadProgress* and
TestWebKitAPI._WKDownload.DownloadMonitorCancel are flaky timeouts
https://bugs.webkit.org/show_bug.cgi?id=198298

Attachment 370906: Patch

https://bugs.webkit.org/attachment.cgi?id=370906&action=review




--- Comment #6 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 370906
  --> https://bugs.webkit.org/attachment.cgi?id=370906
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370906&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:629
> +		   auto resumeDataReference = [resumeData isKindOfClass:[NSData
class]] ? IPC::DataReference { static_cast<const uint8_t*>(resumeData.bytes),
resumeData.length } : IPC::DataReference { };

Silently failing to use resumeData seems quite unfortunate. What are we losing
today, and what will make resuming fail in the future? We should at least
assert that resumeData is one of the types known today.