[webkit-reviews] review granted: [Bug 198367] REGRESSION(r244182): [GTK] Web view no longer updated after re-entering AC mode : [Attachment 370932] Patch

[bugzilla-daemon at webkit.org]

Sergio Villar Senin <svillar at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 198367: REGRESSION(r244182): [GTK] Web view no longer updated after
re-entering AC mode
https://bugs.webkit.org/show_bug.cgi?id=198367

Attachment 370932: Patch

https://bugs.webkit.org/attachment.cgi?id=370932&action=review




--- Comment #2 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 370932
  --> https://bugs.webkit.org/attachment.cgi?id=370932
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370932&action=review

Nice catch!

> Source/WebKit/ChangeLog:9
> +	   RenderingUpdateScheduler. The threaded compositor display refresh
monitor is destroyed without completing the

Mind replacing "threaded compositor display refresh monitor" by
ThreadedDisplayRefreshMonitor ? The former is a bit difficult to read.

> Source/WebKit/ChangeLog:11
> +	   need to ensure we complete the frame request before destrying the
display refresh monitor to leave the

Nit: destrying -> destroying

>
Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefr
eshMonitor.cpp:94
> +	  
DisplayRefreshMonitor::handleDisplayRefreshedNotificationOnMainThread(this);

Looks like DisplayReferehMonitor already protects client notifications so it
should be safe to call this even when the object is about to be destroyed.
Could you confirm that?