[webkit-reviews] review granted: [Bug 198355] oss-fuzz: jsc: Issue 15016: jsc: Abrt in JSC::Wasm::AirIRGenerator::addLocal (15016) : [Attachment 370900] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 29 17:17:42 PDT 2019


Yusuke Suzuki <ysuzuki at apple.com> has granted Justin Michaud
<justin_michaud at apple.com>'s request for review:
Bug 198355: oss-fuzz: jsc: Issue 15016: jsc: Abrt in
JSC::Wasm::AirIRGenerator::addLocal (15016)
https://bugs.webkit.org/show_bug.cgi?id=198355

Attachment 370900: Patch

https://bugs.webkit.org/attachment.cgi?id=370900&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 370900
  --> https://bugs.webkit.org/attachment.cgi?id=370900
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370900&action=review

r=me

> JSTests/wasm/references/is_null.js:18
> -	   .Function("h", { params: ["anyref"], ret: "anyref" })
> +	   .Function("h", { params: ["anyref"], ret: "anyref" }, ["anyref"])
>	     .GetLocal(0)
> +	     .SetLocal(1)
> +	     .GetLocal(1)
>	   .End()

Can we have a test that ensures anyref local is initialized with null?


More information about the webkit-reviews mailing list