[webkit-reviews] review granted: [Bug 198349] check-webkit-style reports false-positive build/include_order warning in WTF C++ source files : [Attachment 370883] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 29 14:37:52 PDT 2019


Alex Christensen <achristensen at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 198349: check-webkit-style reports false-positive build/include_order
warning in WTF C++ source files
https://bugs.webkit.org/show_bug.cgi?id=198349

Attachment 370883: Patch v1

https://bugs.webkit.org/attachment.cgi?id=370883&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 370883
  --> https://bugs.webkit.org/attachment.cgi?id=370883
Patch v1

r=me
This is necessary so that #pragma once can work with WTF headers, which would
otherwise sometimes be included from the build directory and sometimes from the
source causing duplicate declarations from including two copies of the same
header.


More information about the webkit-reviews mailing list