[webkit-reviews] review granted: [Bug 198317] WKWebsiteDataStore API fails to fetch web storage data for non-persistent data store : [Attachment 370815] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Sihui Liu
<sihui_liu at apple.com>'s request for review:
Bug 198317: WKWebsiteDataStore API fails to fetch web storage data for
non-persistent data store
https://bugs.webkit.org/show_bug.cgi?id=198317

Attachment 370815: Patch

https://bugs.webkit.org/attachment.cgi?id=370815&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 370815
  --> https://bugs.webkit.org/attachment.cgi?id=370815
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370815&action=review

R=me with a few comments, mostly stylistic.

> Source/WebKit/NetworkProcess/WebStorage/StorageManager.cpp:94
> +    Ref<StorageArea> getOrCreateStorageArea(SecurityOriginData&&, bool);

bool isEphemeral
Or
enum class IsEphemeral : bool { No, Yes }

> Source/WebKit/WebProcess/WebStorage/StorageAreaMap.cpp:388
> +    default:

Let's remove this default.

> Source/WebKit/WebProcess/WebStorage/StorageNamespaceImpl.cpp:50
> +    return createLocalStorageNamespace(identifier, quotaInBytes, true);

Let's give this "true" a name.
Either use enum class IsEphemeral : bool { No, Yes } or bool isEphemeral =
true;

> Source/WebKit/WebProcess/WebStorage/StorageNamespaceImpl.h:44
> -    static Ref<StorageNamespaceImpl> createLocalStorageNamespace(uint64_t
identifier, unsigned quotaInBytes);
> +    static Ref<StorageNamespaceImpl> createLocalStorageNamespace(uint64_t
identifier, unsigned quotaInBytes, bool isEphemeral = false);

I think with something like this we shouldn't have a default parameter so we
don't forget to state whether it's ephemeral or not.