[webkit-reviews] review granted: [Bug 198307] Add an option to mute audio capture automatically when page is not visible : [Attachment 370851] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 198307: Add an option to mute audio capture automatically when page is not
visible
https://bugs.webkit.org/show_bug.cgi?id=198307

Attachment 370851: Patch

https://bugs.webkit.org/attachment.cgi?id=370851&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 370851
  --> https://bugs.webkit.org/attachment.cgi?id=370851
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370851&action=review

> Source/WebCore/ChangeLog:9
> +	   In case document gets in the background, interrupt the audio track
if the audio factory allows it.

Nit: s/allows/requires/

> Source/WebCore/ChangeLog:10
> +	   CoreAudioCaptureSourceIOS allows to interrupt the audio capture if
the app has not the right background mode.

Nit: s/allows to interrupt the audio source/requires the audio source be
interrupted/