[webkit-reviews] review denied: [Bug 198319] Add write barrier to JSValueInWrappedObject for garbage collection : [Attachment 370818] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 29 06:39:53 PDT 2019
Sam Weinig <sam at webkit.org> has denied Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 198319: Add write barrier to JSValueInWrappedObject for garbage collection
https://bugs.webkit.org/show_bug.cgi?id=198319
Attachment 370818: Patch
https://bugs.webkit.org/attachment.cgi?id=370818&action=review
--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 370818
--> https://bugs.webkit.org/attachment.cgi?id=370818
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=370818&action=review
> Source/WebCore/ChangeLog:9
> + Add write barrier to JSValueInWrappedObject for garbage collection
> + https://bugs.webkit.org/show_bug.cgi?id=198319
> +
> + Reviewed by NOBODY (OOPS!).
> +
> + * bindings/js/JSValueInWrappedObject.h:
> + (WebCore::cachedPropertyValue):
What issue is this fixing? Can a regression test be added?
More information about the webkit-reviews
mailing list