[webkit-reviews] review granted: [Bug 198299] Web Inspector: Timelines: spacing around pie chart is different between CPU and Memory : [Attachment 370764] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 198299: Web Inspector: Timelines: spacing around pie chart is different
between CPU and Memory
https://bugs.webkit.org/show_bug.cgi?id=198299

Attachment 370764: Patch

https://bugs.webkit.org/attachment.cgi?id=370764&action=review




--- Comment #4 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 370764
  --> https://bugs.webkit.org/attachment.cgi?id=370764
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370764&action=review

r=me with nits

> Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.css:97
> +

Unnecessary churn. Was this moved on purpose?

> Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js:57
> +	   case CPUTimelineView.SampleType.JavaScript:

Missing namespace prefix `WI`.

> Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js:214
> +	   this._breakdownLegendScriptElement =
appendLegendRow(this._breakdownLegendElement,
CPUTimelineView.SampleType.JavaScript);

Missing namespace prefix `WI`.

> Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.css:67
> +    border-bottom: 1px solid var(--border-color);

More churn.