[webkit-reviews] review granted: [Bug 198294] Use scroll-velocity-based tile coverage for overflow:scroll : [Attachment 370788] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 198294: Use scroll-velocity-based tile coverage for overflow:scroll
https://bugs.webkit.org/show_bug.cgi?id=198294

Attachment 370788: Patch

https://bugs.webkit.org/attachment.cgi?id=370788&action=review




--- Comment #16 from Tim Horton <thorton at apple.com> ---
Comment on attachment 370788
  --> https://bugs.webkit.org/attachment.cgi?id=370788
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370788&action=review

> Source/WebCore/platform/graphics/ca/TileController.cpp:433
> +    // FIXME: look at how far the document can scroll in each dimension.

Capital L :D

> Source/WebCore/platform/graphics/ca/TileController.cpp:455
> +    auto expandRectWithinRect = [](const FloatRect& rect, const FloatSize&
newSize, const FloatRect& constrainingRect) {

Why this lambda? It's only called once and doesn't make use of early returns or
anything.