[webkit-reviews] review granted: [Bug 198247] Limit run-benchmark http server to specific interface. : [Attachment 370711] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 28 14:02:35 PDT 2019


Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 198247: Limit run-benchmark http server to specific interface.
https://bugs.webkit.org/show_bug.cgi?id=198247

Attachment 370711: Patch

https://bugs.webkit.org/attachment.cgi?id=370711&action=review




--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 370711
  --> https://bugs.webkit.org/attachment.cgi?id=370711
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370711&action=review

>
Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_d
river.py:69
> +	   self._check_http_server_is_running()

We should probably call this _wait_for_http_server or something.
Otherwise, it doesn't tell us what it's doing after checking the status.


More information about the webkit-reviews mailing list