[webkit-reviews] review granted: [Bug 198292] [async scrolling] Fixed positioning inside stacking context overflow scroll is jumpy : [Attachment 370738] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 198292: [async scrolling] Fixed positioning inside stacking context
overflow scroll is jumpy
https://bugs.webkit.org/show_bug.cgi?id=198292

Attachment 370738: patch

https://bugs.webkit.org/attachment.cgi?id=370738&action=review




--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 370738
  --> https://bugs.webkit.org/attachment.cgi?id=370738
patch

Old code seems to have "cleverly" avoided a source of n^2 algorithm cost, by
computing as we descend the tree. New code walks the parent list so is
potentially slower for very deep trees. Makes me wonder if we should have some
kind of stress test for a deeply nested tree. I’m sure many of our algorithms
have such issues, not sure what our performance/scaling goals are for them.