[webkit-reviews] review granted: [Bug 198282] [LFC][IFC] Decouple line layout and processing inline runs. : [Attachment 370713] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 28 02:38:08 PDT 2019


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 198282: [LFC][IFC] Decouple line layout and processing inline runs.
https://bugs.webkit.org/show_bug.cgi?id=198282

Attachment 370713: Patch

https://bugs.webkit.org/attachment.cgi?id=370713&action=review




--- Comment #5 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 370713
  --> https://bugs.webkit.org/attachment.cgi?id=370713
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370713&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.h:62
> +	   unsigned createInlineRunsForLine(Line&, unsigned
firstInlineItemIndex) const;

Not super clear what the return value means.


More information about the webkit-reviews mailing list