[webkit-reviews] review granted: [Bug 198267] [iOS] Dropping in an editable element should result in a ranged selection : [Attachment 370669] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 198267: [iOS] Dropping in an editable element should result in a ranged
selection
https://bugs.webkit.org/show_bug.cgi?id=198267

Attachment 370669: Patch

https://bugs.webkit.org/attachment.cgi?id=370669&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 370669
  --> https://bugs.webkit.org/attachment.cgi?id=370669
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370669&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:881
>      static auto defaultTextIndicatorOptionsForEditDrag =
TextIndicatorOptionIncludeSnapshotOfAllVisibleContentWithoutSelection |
TextIndicatorOptionExpandClipBeyondVisibleRect |
TextIndicatorOptionPaintAllContent |
TextIndicatorOptionIncludeMarginIfRangeMatchesSelection |
TextIndicatorOptionPaintBackgrounds |
TextIndicatorOptionComputeEstimatedBackgroundColor|
TextIndicatorOptionUseSelectionRectForSizing |
TextIndicatorOptionIncludeSnapshotWithSelectionHighlight;

Ho-ly crap