[webkit-reviews] review granted: [Bug 198256] Fix opensource build of testapi : [Attachment 370672] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 27 13:09:06 PDT 2019

Alexey Proskuryakov <ap at webkit.org> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 198256: Fix opensource build of testapi

Attachment 370672: Patch


--- Comment #7 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 370672
  --> https://bugs.webkit.org/attachment.cgi?id=370672

View in context: https://bugs.webkit.org/attachment.cgi?id=370672&action=review

> Source/JavaScriptCore/API/JSScript.mm:80
> +	       createError([NSString stringWithFormat:@"Cache path `%@` already
exists and is not a file", static_cast<NSString*>(systemPath)], error);

Please add a space between NSString and the star, since this is an Objective-C
class name.

> Source/JavaScriptCore/API/JSScript.mm:87
> +	   createError([NSString stringWithFormat:@"Cache path `%@` does not
contain in a valid directory", static_cast<NSString*>(systemPath)], error);


> Source/JavaScriptCore/API/JSScript.mm:92
> +	   createError([NSString stringWithFormat:@"Cache directory `%@` is not
a directory or does not exist", static_cast<NSString*>(directory)], error);


More information about the webkit-reviews mailing list