[webkit-reviews] review denied: [Bug 197873] [CURL] Fix crashing SocketStreamHandle. : [Attachment 370634] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun May 26 19:11:05 PDT 2019
Fujii Hironori <Hironori.Fujii at sony.com> has denied Takashi Komori
<Takashi.Komori at sony.com>'s request for review:
Bug 197873: [CURL] Fix crashing SocketStreamHandle.
https://bugs.webkit.org/show_bug.cgi?id=197873
Attachment 370634: Patch
https://bugs.webkit.org/attachment.cgi?id=370634&action=review
--- Comment #35 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 370634
--> https://bugs.webkit.org/attachment.cgi?id=370634
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=370634&action=review
> Source/WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp:82
> + auto writeData = std::make_unique<Vector<uint8_t>>(length);
The original code is using makeUniqueArray. I think makeUniqueArray is better.
More information about the webkit-reviews
mailing list