[webkit-reviews] review granted: [Bug 198243] [iOS] Dropped text, attachments, and images should animate into place : [Attachment 370646] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 26 02:06:21 PDT 2019

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 198243: [iOS] Dropped text, attachments, and images should animate into

Attachment 370646: Patch


--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 370646
  --> https://bugs.webkit.org/attachment.cgi?id=370646

View in context: https://bugs.webkit.org/attachment.cgi?id=370646&action=review

> Source/WebKit/UIProcess/ios/DragDropInteractionState.mm:200
> +    UITargetedDragPreview *preview =
createTargetedDragPreview(textIndicatorImage.get(), contentView,
previewContainer, indicator.textBoundingRectInRootViewCoordinates,
indicator.textRectsInBoundingRectCoordinates, [UIColor
colorWithCGColor:cachedCGColor(indicator.estimatedBackgroundColor)], nil);

A -create method that doesn't return a smart pointer? Weird.

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:844
> +	   for (TextIterator iterator(range.get()); !iterator.atEnd();
iterator.advance()) {

Why TextIterator? I think just one of the nice DOM child traversal things would
be fine, no?

More information about the webkit-reviews mailing list