[webkit-reviews] review granted: [Bug 198247] Limit run-benchmark http server to specific interface. : [Attachment 370635] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 25 16:15:04 PDT 2019


Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 198247: Limit run-benchmark http server to specific interface.
https://bugs.webkit.org/show_bug.cgi?id=198247

Attachment 370635: Patch

https://bugs.webkit.org/attachment.cgi?id=370635&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 370635
  --> https://bugs.webkit.org/attachment.cgi?id=370635
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370635&action=review

>
Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_d
river.py:58
> +		       self._server_port = int(re.search('TCP .*:(\d+)
\(LISTEN\)', output).group(1))

This will greedily match any text. Is that really intended? Isn't what we want
.*? instead?


More information about the webkit-reviews mailing list