[webkit-reviews] review granted: [Bug 198236] Update sandbox rules for more News use cases : [Attachment 370597] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 24 16:58:38 PDT 2019


Alexey Proskuryakov <ap at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 198236: Update sandbox rules for more News use cases
https://bugs.webkit.org/show_bug.cgi?id=198236

Attachment 370597: Patch

https://bugs.webkit.org/attachment.cgi?id=370597&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 370597
  --> https://bugs.webkit.org/attachment.cgi?id=370597
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370597&action=review

> Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:46
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300 || PLATFORM(IOSMAC)

Please remove most of these #ifs. 10.13 is the minimum.


More information about the webkit-reviews mailing list