[webkit-reviews] review granted: [Bug 198102] [WASM-References] Support Anyref in globals : [Attachment 370584] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Justin Michaud
<justin_michaud at apple.com>'s request for review:
Bug 198102: [WASM-References] Support Anyref in globals
https://bugs.webkit.org/show_bug.cgi?id=198102

Attachment 370584: Patch

https://bugs.webkit.org/attachment.cgi?id=370584&action=review




--- Comment #20 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 370584
  --> https://bugs.webkit.org/attachment.cgi?id=370584
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370584&action=review

r=me

> Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp:1097
> +    auto* patch = addPatchpoint(B3::Void);

let's call this doFence

> Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp:1100
> +    patch->setGenerator([] (CCallHelpers& jit, const
B3::StackmapGenerationParams&) {
> +	   jit.memoryFence();
> +    });

nit: Let's file a follow up, but B3/Air both have Fence instructions. We should
just use those instead of a patchpoint and make sure we have the proper
effects.

> Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:680
> +    B3::PatchpointValue* doBarrier =
m_currentBlock->appendNew<B3::PatchpointValue>(m_proc, B3::Void, origin());

let's call this doFence

> Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.h:95
> +    VM* m_vm; // Pointer so that offsetof works.

no need for comment.