[webkit-reviews] review granted: [Bug 197198] [LFC][IFC] Introduce DisplayRun to display tree : [Attachment 370549] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 24 14:40:47 PDT 2019


Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 197198: [LFC][IFC] Introduce DisplayRun to display tree
https://bugs.webkit.org/show_bug.cgi?id=197198

Attachment 370549: Patch

https://bugs.webkit.org/attachment.cgi?id=370549&action=review




--- Comment #9 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 370549
  --> https://bugs.webkit.org/attachment.cgi?id=370549
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370549&action=review

Cool patch!

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:285
> +    // Traverse the tree and create inline items out of containers and leaf
node. This essentially truns the tree inline structure into a flat one.

"leaf nodes"
"turns"

> Source/WebCore/layout/inlineformatting/InlineLineBox.h:56
> +    {
> +    }

Weird indent.


More information about the webkit-reviews mailing list