[webkit-reviews] review granted: [Bug 198214] Update messages_unittest.py after https://trac.webkit.org/changeset/245715 : [Attachment 370563] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 24 09:58:19 PDT 2019


Alexey Proskuryakov <ap at webkit.org> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 198214: Update messages_unittest.py after
https://trac.webkit.org/changeset/245715
https://bugs.webkit.org/show_bug.cgi?id=198214

Attachment 370563: Patch

https://bugs.webkit.org/attachment.cgi?id=370563&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 370563
  --> https://bugs.webkit.org/attachment.cgi?id=370563
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370563&action=review

> Source/WebKit/ChangeLog:3
> +	   Update messages_unittest.py after
https://trac.webkit.org/changeset/245715

Probably enough to say r245715 here.

> Source/WebKit/ChangeLog:9
> +	   Small update to messages.py so that cancelReply is called in case of
decoding error.

The patch looks good overall, but the ChangeLog confuses me. Isn't the change
to messages.py more important? I know that we don't expect this path to be
taken, but it has some potential for changing observed behavior anyway. If that
happens, everyone will be confused by the title.


More information about the webkit-reviews mailing list