[webkit-reviews] review granted: [Bug 198216] Asssertion failure in dispatchSubtreeModifiedEvent due to TextFieldInputType updating UA shadow tree inside Element::removedFromAncestor : [Attachment 370565] Fixes the bug

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 198216: Asssertion failure in dispatchSubtreeModifiedEvent due to
TextFieldInputType updating UA shadow tree inside Element::removedFromAncestor
https://bugs.webkit.org/show_bug.cgi?id=198216

Attachment 370565: Fixes the bug

https://bugs.webkit.org/attachment.cgi?id=370565&action=review




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 370565
  --> https://bugs.webkit.org/attachment.cgi?id=370565
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=370565&action=review

r=me

> Source/WebCore/html/shadow/DataListButtonElement.cpp:-52
> -    setPseudo(AtomicString("-webkit-list-button",
AtomicString::ConstructFromLiteral));

Why do we prefer to call 'setPseudo' on the result of this constructed object,
rather than during construction here? It seems like it would be easy to forget
to do this work, wouldn't it?