[webkit-reviews] review granted: [Bug 198207] Web Inspector: prevent stripping `console.assert` if it's used inside a string : [Attachment 370548] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 23 19:33:57 PDT 2019


Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 198207: Web Inspector: prevent stripping `console.assert` if it's used
inside a string
https://bugs.webkit.org/show_bug.cgi?id=198207

Attachment 370548: Patch

https://bugs.webkit.org/attachment.cgi?id=370548&action=review




--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 370548
  --> https://bugs.webkit.org/attachment.cgi?id=370548
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370548&action=review

sh

> Source/WebInspectorUI/Scripts/remove-console-asserts.pl:59
> +	       next if /^.*?["'`].*?console\.assert/;

/["'`].*?console\.assert/


More information about the webkit-reviews mailing list