[webkit-reviews] review denied: [Bug 195132] Web Inspector: Provide UIString descriptions to improve localizations : [Attachment 370452] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 23 19:18:14 PDT 2019
Devin Rousso <drousso at apple.com> has denied review:
Bug 195132: Web Inspector: Provide UIString descriptions to improve
localizations
https://bugs.webkit.org/show_bug.cgi?id=195132
Attachment 370452: Patch
https://bugs.webkit.org/attachment.cgi?id=370452&action=review
--- Comment #38 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 370452
--> https://bugs.webkit.org/attachment.cgi?id=370452
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=370452&action=review
> Source/WebInspectorUI/UserInterface/Base/LoadLocalizedStrings.js:99
> + return WI.UIString("Assertion Failures", "Break (pause) when
console.assert() fails");
The reason this patch isn't working is because we strip all `console.assert`
lines when creating a production build. Setting `my $shouldCombineMain = 1;`
in WebInspectorUI/Scripts/copy-user-interface-resources.pl will reproduce.
<https://webkit.org/b/198207>
More information about the webkit-reviews
mailing list