[webkit-reviews] review denied: [Bug 198102] [WASM-References] Support Anyref in globals : [Attachment 370525] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 23 16:47:31 PDT 2019

Saam Barati <sbarati at apple.com> has denied Justin Michaud
<justin_michaud at apple.com>'s request for review:
Bug 198102: [WASM-References] Support Anyref in globals

Attachment 370525: Patch


--- Comment #10 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 370525
  --> https://bugs.webkit.org/attachment.cgi?id=370525

View in context: https://bugs.webkit.org/attachment.cgi?id=370525&action=review

> Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp:534
> +	   append(block, Move, Arg::
> +	   immPtr(tagCFunctionPtr<void*>(func, B3CCallPtrTag)), callee);

style: oops

> Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:686
> +	   m_currentBlock->appendNew<Value>(m_proc, Above, origin(), cellState,
m_currentBlock->appendNew<Const32Value>(m_proc, origin(), blackThreshold)),

This is wrong. You need to reload the cell state here.

More information about the webkit-reviews mailing list