[webkit-reviews] review granted: [Bug 198193] [WHLSL] Property resolver needs to recurse to handle the base when simplifying rvalues : [Attachment 370518] patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 198193: [WHLSL] Property resolver needs to recurse to handle the base when
simplifying rvalues
https://bugs.webkit.org/show_bug.cgi?id=198193

Attachment 370518: patch

https://bugs.webkit.org/attachment.cgi?id=370518&action=review




--- Comment #2 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 370518
  --> https://bugs.webkit.org/attachment.cgi?id=370518
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370518&action=review

Cool.

> LayoutTests/webgpu/whlsl-nested-dot-expression-rvalue.html:11
> +    float shade : attribute(0);

I think you should remove the " : attribute(0)"