[webkit-reviews] review granted: [Bug 198175] [WHLSL] Add a helper for in-place AST mutation : [Attachment 370510] patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 198175: [WHLSL] Add a helper for in-place AST mutation
https://bugs.webkit.org/show_bug.cgi?id=198175

Attachment 370510: patch

https://bugs.webkit.org/attachment.cgi?id=370510&action=review




--- Comment #3 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 370510
  --> https://bugs.webkit.org/attachment.cgi?id=370510
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370510&action=review

> Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNode.h:56
> +    return new (&old) New(std::forward<Args>(args)...);

Don’t you have to save the address of “old” before you call its destructor?