[webkit-reviews] review granted: [Bug 198152] Deprecate more preview API : [Attachment 370474] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 198152: Deprecate more preview API
https://bugs.webkit.org/show_bug.cgi?id=198152

Attachment 370474: Patch

https://bugs.webkit.org/attachment.cgi?id=370474&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 370474
  --> https://bugs.webkit.org/attachment.cgi?id=370474
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370474&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKPreviewElementInfo.mm:32
> +#pragma clang diagnostic push
> +#pragma clang diagnostic ignored "-Wdeprecated-implementations"

IGNORE_WARNINGS_BEGIN("deprecated-implementations")

> Source/WebKit/UIProcess/API/Cocoa/WKPreviewElementInfo.mm:34
> +#pragma clang diagnostic pop

IGNORE_WARNINGS_END

>
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateI
OS.h:70
> +    OptionSet<WebCore::TouchAction> activeTouchActions() const { return
m_activeTouchActions; }

Haha