[webkit-reviews] review granted: [Bug 139681] Touch support is reported even when the device doesn't have a touch screen : [Attachment 370502] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 139681: Touch support is reported even when the device doesn't have a touch
screen
https://bugs.webkit.org/show_bug.cgi?id=139681

Attachment 370502: Patch

https://bugs.webkit.org/attachment.cgi?id=370502&action=review




--- Comment #25 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 370502
  --> https://bugs.webkit.org/attachment.cgi?id=370502
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370502&action=review

> Source/WebCore/page/RuntimeEnabledFeatures.h:536
> +    Optional<bool> m_touchEventsEnabled;

This seems confusing. The semantics of Optional don't lead themselves to a
natural interpretation of this member variable. What does it mean for
m_touchEventsEnabled to be unset: neither enabled nor disabled?