[webkit-reviews] review granted: [Bug 198105] run-webkit-tests: Remove feature detection support : [Attachment 370477] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 23 07:05:14 PDT 2019


Jonathan Bedard <jbedard at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 198105: run-webkit-tests: Remove feature detection support
https://bugs.webkit.org/show_bug.cgi?id=198105

Attachment 370477: Patch

https://bugs.webkit.org/attachment.cgi?id=370477&action=review




--- Comment #5 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 370477
  --> https://bugs.webkit.org/attachment.cgi?id=370477
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370477&action=review

> Tools/ChangeLog:8
> +	   Feature detection support has been added to Windows port's DRT and

Should be: 'Feature detection support was added to DRT for Windows and...'

> Tools/ChangeLog:9
> +	   old run-webkit-tests in Bug 35610. It has been added for NRWT in

Likewise: 'It was added for NRWT in...'

> Tools/ChangeLog:10
> +	   Bug 41842. But, it doesn't work for Windows port's DRT because

'But it doesn't work for DRT for Windows because of...'


More information about the webkit-reviews mailing list