[webkit-reviews] review denied: [Bug 198102] [WASM-References] Support Anyref in globals : [Attachment 370485] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 22 22:37:00 PDT 2019

Saam Barati <sbarati at apple.com> has denied Justin Michaud
<justin_michaud at apple.com>'s request for review:
Bug 198102: [WASM-References] Support Anyref in globals

Attachment 370485: Patch


--- Comment #7 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 370485
  --> https://bugs.webkit.org/attachment.cgi?id=370485

View in context: https://bugs.webkit.org/attachment.cgi?id=370485&action=review

Would be good to try to get a test that crashes. Probably run with
collectContinuously=1, and allocate and store repeatedly in a loop

> Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:675
> +	   FrequentedBlock(continuation), FrequentedBlock(slowPath2,

Same bug

More information about the webkit-reviews mailing list