[webkit-reviews] review canceled: [Bug 198105] run-webkit-tests: Remove feature detection support : [Attachment 370391] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 22 19:19:11 PDT 2019


Fujii Hironori <Hironori.Fujii at sony.com> has canceled Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 198105: run-webkit-tests: Remove feature detection support
https://bugs.webkit.org/show_bug.cgi?id=198105

Attachment 370391: Patch

https://bugs.webkit.org/attachment.cgi?id=370391&action=review




--- Comment #3 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 370391
  --> https://bugs.webkit.org/attachment.cgi?id=370391
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370391&action=review

>> LayoutTests/ChangeLog:10
>> +	    Skip all compositing, animations/3d and transforms/3d temporarily.
> 
> If this is actually temporary, we should put FIXMEs in expectations,
otherwise we'll lose track of why they were skipped.

In WinCairo TestExpectations, I added the Skip in "TEMPORARY SKIPS" section. I
think no additional comment is needed.
https://github.com/WebKit/webkit/blob/d3d6b28920d2f449f918a3c2da9c48d15bb59002/
LayoutTests/platform/wincairo/TestExpectations#L1502

In AppleWin TestExpectations, I'm going to move the Skip to "UNREVIEWED
failures" section.
https://github.com/WebKit/webkit/blob/d3d6b28920d2f449f918a3c2da9c48d15bb59002/
LayoutTests/platform/win/TestExpectations#L2601


More information about the webkit-reviews mailing list