[webkit-reviews] review granted: [Bug 198098] [Win][CMake] Pass architecture to cmake via -A for both x64 and Win32 : [Attachment 370458] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 22 18:54:56 PDT 2019
Don Olmstead <don.olmstead at sony.com> has granted review:
Bug 198098: [Win][CMake] Pass architecture to cmake via -A for both x64 and
Win32
https://bugs.webkit.org/show_bug.cgi?id=198098
Attachment 370458: Patch
https://bugs.webkit.org/attachment.cgi?id=370458&action=review
--- Comment #6 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 370458
--> https://bugs.webkit.org/attachment.cgi?id=370458
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=370458&action=review
r=me with changes
> Tools/ChangeLog:14
> + Reviewed by NOBODY (OOPS!).
> +
> + * Scripts/webkitdirs.pm:
> + (getVisualStudioToolset): Get toolset name for cmake/msbuild
> + (getMSBuildPlatformArgument): Update to use getVisualStudioToolset
> + (getCMakeWindowsToolsetArgument): Get -A argument for cmake
> + based on toolset
> + (generateBuildSystemFromCMakeProject): Remove explicit -A x64
> + in 64-bit mode in favor of new getCMakeWindowsToolsetArgument.
Can you add why this is being done? I thought it was because with 2019 the
default architecture was changed from Win32 to whatever the host operating
system is.
More information about the webkit-reviews
mailing list