[webkit-reviews] review granted: [Bug 198139] Fix scrolling tree state for more obscure combinations of positioning and paint order : [Attachment 370447] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 198139: Fix scrolling tree state for more obscure combinations of
positioning and paint order
https://bugs.webkit.org/show_bug.cgi?id=198139

Attachment 370447: Patch

https://bugs.webkit.org/attachment.cgi?id=370447&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 370447
  --> https://bugs.webkit.org/attachment.cgi?id=370447
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370447&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1800
> +// This is a simplified version of containing block walking that only
handles absolute position.
> +static AncestorTraversal traverseAncestorLayers(const RenderLayer& layer,
const WTF::Function<AncestorTraversal(const RenderLayer&, bool
inContainingBlockChain, bool isPaintOrderAncestor)>& ancestorFunc)

Using template argument instead of WTF::Function would avoid unnecessary
virtual function calls.