[webkit-reviews] review granted: [Bug 198138] createListFromArrayLike should throw if value is not an object : [Attachment 370440] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 198138: createListFromArrayLike should throw if value is not an object
https://bugs.webkit.org/show_bug.cgi?id=198138

Attachment 370440: Patch

https://bugs.webkit.org/attachment.cgi?id=370440&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 370440
  --> https://bugs.webkit.org/attachment.cgi?id=370440
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370440&action=review

> Source/JavaScriptCore/runtime/JSObjectInlines.h:42
> +	   throwTypeError(exec, scope, errorMessage);

Can we throw an error with the other error message like "ArrayLike is not an
object"_s? `createListFromArrayLike`'s caller passes the errorMessage related
to Symbol / String.