[webkit-reviews] review granted: [Bug 198132] [Paste] Add support for preferred presentation size when pasting an image : [Attachment 370425] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 22 11:12:43 PDT 2019


Wenson Hsieh <wenson_hsieh at apple.com> has granted zalan <zalan at apple.com>'s
request for review:
Bug 198132: [Paste] Add support for preferred presentation size when pasting an
image
https://bugs.webkit.org/show_bug.cgi?id=198132

Attachment 370425: Patch

https://bugs.webkit.org/attachment.cgi?id=370425&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 370425
  --> https://bugs.webkit.org/attachment.cgi?id=370425
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370425&action=review

r=mews

> Source/WebCore/platform/ios/PasteboardIOS.mm:184
> +Pasteboard::ReaderResult
Pasteboard::readPasteboardWebContentDataForType(PasteboardWebContentReader&
reader, PasteboardStrategy& strategy, NSString *type, PasteboardItemInfo
itemInfo, int itemIndex)

Is there a reason you opted for PasteboardItemInfo over const
PasteboardItemInfo& here?


More information about the webkit-reviews mailing list