[webkit-reviews] review granted: [Bug 198124] [iOS] Compatibility mouse events aren't prevented by calling preventDefault() on pointerdown : [Attachment 370417] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 198124: [iOS] Compatibility mouse events aren't prevented by calling
preventDefault() on pointerdown
https://bugs.webkit.org/show_bug.cgi?id=198124

Attachment 370417: Patch

https://bugs.webkit.org/attachment.cgi?id=370417&action=review




--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 370417
  --> https://bugs.webkit.org/attachment.cgi?id=370417
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370417&action=review

> Source/WebKit/ChangeLog:376
> -	   * NetworkProcess/WebStorage/LocalStorageDatabaseTracker.cpp: Renamed
from Source/WebKit/UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp.
> +	   * NetworkProcess/WebStorage/LocalStorageDatabaseTracker.cpp: Renamed
from Source/WebKit/UIProcess/WebStorage/LocalStorageDatabaseTracker.pp.

This seems wrong

> Source/WebCore/page/PointerCaptureController.cpp:149
> +void PointerCaptureController::forgetPointer(PointerID pointerId)

Forget! Interesting. Remove? DidRemove? Forget is fine too.

> Source/WebCore/platform/PlatformMouseEvent.h:65
> -			      int clickCount, bool shiftKey, bool ctrlKey, bool
altKey, bool metaKey, WallTime timestamp, double force, SyntheticClickType
syntheticClickType)
> +			      int clickCount, bool shiftKey, bool ctrlKey, bool
altKey, bool metaKey, WallTime timestamp, double force, SyntheticClickType
syntheticClickType, PointerID pointerId = mousePointerID())

This is getting ridiculous

> Source/WebKit/UIProcess/ios/WKSyntheticTapGestureRecognizer.h:40
> + at property (nonatomic, weak) UIWebTouchEventsGestureRecognizer*
supportingWebTouchEventsGestureRecognizer;
> + at property (nonatomic, readonly) NSNumber* lastActiveTouchIdentifier;

Stars are on the wrong side 🤷‍♂️

> Source/WebKit/UIProcess/ios/WKSyntheticTapGestureRecognizer.m:89
> +	       return;

Should this just `break` out of the for() instead of returning from the
function entirely? (just imagining someone coming along later and wanting to
add code to touchesEnded)

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1040
> +void WebPage::forgetPointer(WebCore::PointerID pointerId)

The name is still bothering me. Maybe it's the super generic "pointer".