[webkit-reviews] review granted: [Bug 195777] Web Inspector: provide a way to reset all settings : [Attachment 370385] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 195777: Web Inspector: provide a way to reset all settings
https://bugs.webkit.org/show_bug.cgi?id=195777

Attachment 370385: Patch

https://bugs.webkit.org/attachment.cgi?id=370385&action=review




--- Comment #13 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 370385
  --> https://bugs.webkit.org/attachment.cgi?id=370385
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370385&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:364
> +	       WI.ObjectStore.reset();
> +	       InspectorFrontendHost.reopen();

ObjectStore.reset() is async and we should probably wait for it. Should this
instead be:

    resetInspectorButton.addEventListener("click", async (event) => {
	WI.Setting.reset();
	await WI.ObjectStore.reset();
	InspectorFrontendHost.reopen();
    });