[webkit-reviews] review granted: [Bug 198078] Implement Feature policy self/none/* parsing : [Attachment 370348] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 198078: Implement Feature policy self/none/* parsing
https://bugs.webkit.org/show_bug.cgi?id=198078

Attachment 370348: Patch

https://bugs.webkit.org/attachment.cgi?id=370348&action=review




--- Comment #7 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 370348
  --> https://bugs.webkit.org/attachment.cgi?id=370348
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370348&action=review

> Source/WebCore/html/FeaturePolicy.cpp:121
> +    if (!isCameraInitialized)

I don’t understand why we add the origin to the allowed list if “camera” is NOT
in the attribute, so it is probably worth adding a comment here to explain.