[webkit-reviews] review granted: [Bug 198078] Implement Feature policy self/none/* parsing : [Attachment 370348] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 21 16:29:10 PDT 2019

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 198078: Implement Feature policy self/none/* parsing

Attachment 370348: Patch


--- Comment #7 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 370348
  --> https://bugs.webkit.org/attachment.cgi?id=370348

View in context: https://bugs.webkit.org/attachment.cgi?id=370348&action=review

> Source/WebCore/html/FeaturePolicy.cpp:121
> +    if (!isCameraInitialized)

I don’t understand why we add the origin to the allowed list if “camera” is NOT
in the attribute, so it is probably worth adding a comment here to explain.

More information about the webkit-reviews mailing list