[webkit-reviews] review granted: [Bug 197528] font-optical-sizing applies the wrong variation value : [Attachment 370282] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 197528: font-optical-sizing applies the wrong variation value
https://bugs.webkit.org/show_bug.cgi?id=197528

Attachment 370282: Patch

https://bugs.webkit.org/attachment.cgi?id=370282&action=review




--- Comment #41 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 370282
  --> https://bugs.webkit.org/attachment.cgi?id=370282
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370282&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:557
> +    if (!originalFont || (features.isEmpty() && !forceVariations &&
variations.isEmpty() && textRenderingMode ==
TextRenderingMode::AutoTextRendering && variantSettings.isAllNormal() &&
fontOpticalSizing == FontOpticalSizing::Enabled && !forceOpticalSizingOn
> +	   && (!fontFaceFeatures || fontFaceFeatures->isEmpty()) &&
(!fontFaceVariantSettings || fontFaceVariantSettings->isAllNormal())))

The test would read better with some sensibly named helper booleans, or as a
lambda function.