[webkit-reviews] review denied: [Bug 198033] ErrorObjectView display black link in dark mode : [Attachment 370265] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has denied Zhifei Fang
<zhifei_fang at apple.com>'s request for review:
Bug 198033: ErrorObjectView display black link in dark mode
https://bugs.webkit.org/show_bug.cgi?id=198033

Attachment 370265: Patch

https://bugs.webkit.org/attachment.cgi?id=370265&action=review




--- Comment #13 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 370265
  --> https://bugs.webkit.org/attachment.cgi?id=370265
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370265&action=review

r-

> Source/WebInspectorUI/UserInterface/Views/ErrorObjectView.css:57
> +    .error-object-link-container {

This doesn't fix the issue for me, as there's a `.console-message .go-to-arrow`
that has a higher specificity.	Please match the styling of `.call-frame
.subtitle`, `.call-frame .separator`, and `.call-frame .subtitle .source-link`
so we have the same coloring everywhere.

I also agree with @Nikita in that we should always use the CSS variable in
light and dark mode.