[webkit-reviews] review granted: [Bug 197898] Only cache bytecode for API clients in data vaults : [Attachment 370220] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 197898: Only cache bytecode for API clients in data vaults
https://bugs.webkit.org/show_bug.cgi?id=197898

Attachment 370220: Patch

https://bugs.webkit.org/attachment.cgi?id=370220&action=review




--- Comment #11 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 370220
  --> https://bugs.webkit.org/attachment.cgi?id=370220
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370220&action=review

r=me unless this will break open source API tests.

> Source/JavaScriptCore/API/JSScript.mm:107
> +    if (!validateBytecodeCachePath(cachePath, error))
> +	   return nil;

Should we only do this check if the client is an internal client? Won't this
cause API tests for builds that are not using the internal SDK to fail?

Maybe I'm missing something though.

> Source/JavaScriptCore/API/JSScript.mm:121
> +    if (!validateBytecodeCachePath(cachePath, error))

Ditto.